search

atmoschem / eixport

Export Emissions to Atmospheric Models
https://atmoschem.github.io/eixport/
Other
27 stars 10 forks source link

Wrong Molar Masses #78

Open C130PA5 opened 8 months ago

C130PA5 commented 8 months ago

I don't know if this repository is still used and updated. However, I noticed that molar masses in the chem_edgar.R file are wrong.

ibarraespinosa commented 8 months ago

Hi @C130PA5 , thanks for catching up that error. Maybe you can post the molar mass here, or you can provide a pull request and I can add you as contributor

C130PA5 commented 7 months ago

For SO2, the total molar mass is 64 however in the code it is 64+162. This occurs in the entire file. Example:
E_SO2 <- bp$so2 / (64 + 16 2) # emis_opt$eradm[2] E_NO <- bp$nox * 0.9 / (14 + 16) # emis_opt$eradm[3] E_CO <- bp$co / (12 + 18) # emis_opt$eradm[4]

ibarraespinosa commented 7 months ago

I see

On Tue, Jan 23, 2024, 7:29 AM Charbel Abdallah @.***> wrote:

For SO2, the total molar mass is 64 however in the code it is 64+162. This occurs in the entire file. Example: E_SO2 <- bp$so2 / (64 + 16 2) # emis_opt$eradm[2] E_NO <- bp$nox * 0.9 / (14 + 16) # emis_opt$eradm[3] E_CO <- bp$co / (12 + 18) # emis_opt$eradm[4]

— Reply to this email directly, view it on GitHub https://github.com/atmoschem/eixport/issues/78#issuecomment-1906173045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74EOJGVDTFWBZRER5QTYP7CMDAVCNFSM6AAAAABBWRXO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGE3TGMBUGU . You are receiving this because you were assigned.Message ID: @.***>