search

atmtools / arts

The Atmospheric Radiative Transfer Simulator
https://www.radiativetransfer.org/
Other
66 stars 30 forks source link

Release ARTS3 #56

Open erikssonpatrick opened 5 years ago

erikssonpatrick commented 5 years ago

Things to fix and consider for ARTS-3 (for now draft for meeting later today):

Mandatory:

Would be very nice:

riclarsson commented 5 years ago

Patrick,

Please can you clarify Remove all obsolete code and features? What defines this? Because, to me, it seems we should first of all remove all control files that are not run or included by the test-setup. We cannot guarantee that they are working anyways. Then we would have to remove all methods that are not used in any of the remaining control files? They could be working and they could be used by others so we need an opinion on each of them. An opinion here means that someone with the opinion creates a feature test-file to allow the method to remain in ARTS. But what is next? Do we remove all inner functions of ARTS that are not used? Or do we even rearrange so that the lot of the helper-functions that don't really need a header because they are only called once has their header removed?

About Complete switch to new "radiative transfer system" #41 , I sent in some code a while back that mostly solves this. There is some problems but the difference between new and old method seems smaller than between either and the perturbed case. So there is probably something fundamental wrong in both.

erikssonpatrick commented 5 years ago

All: Of course, you can not edit my post. So let's go for this. Add your points in a comment and I update my initial comment. And when you think your stuff is correctly reflected in the list, remove your comment. All to not get a very long thread here.

Richard: Added ARTSCAT-6. Yes, #41 is basically closed. I just wait for a last test by Simon before closing that issue. When it comes to the control files we provide, I did not add much. The main reason is that I don't think we manage to make a proper revision of those files before March. But I agree that cfiles not used should be removed, or be included in some test. Added this as mandatory. I don't think we shall make Python mandatory, but that can be discussed. And started a new category. I mainly meant that if there are internal functions that are not used, they shall be removed. There are likely still also WSMs that are replaced by newer ones, and they shall be removed. I can not see that we can define a test for exactly every option in ARTS ...