search

atmtools / arts

The Atmospheric Radiative Transfer Simulator
https://www.radiativetransfer.org/
Other
62 stars 28 forks source link

V2.6.x addsungeo #770

Closed m-brath closed 2 months ago

m-brath commented 3 months ago

Add a WSM to change the geometric varaibales of a sun.

riclarsson commented 3 months ago

First of all, this is not a bug fix but a new feature in 2.6. I do not think it should be added to 2.6. Are you or anyone else really using .arts files for 2.6 simulations? Because all that this is doing here can already be done via the python interface of 2.6, and none of it depends on any workspace variables so it is not useful from workspace-flow either.

m-brath commented 3 months ago

I agree that the geometric properties can changed using python, but it it is not recommended to use python code inside an agenda. This function is needed, if you want to change the sun position or any other geometric property of the sun within an agenda like dobatch_calc_agenda or ybatch_calc_agenda.