Revise humidity models - Githubissues

atmtools / konrad

Implementation of a radiative-convective equilibrium model.

MIT License

19 stars 18 forks source link

Revise humidity models #108

Closed lkluft closed 4 years ago

lkluft commented 4 years ago

This PR:

Adds the class CacheFromAtmosphere to calculate and store the initial relative humidity profile
Removes the NoCoupling stratospheric coupling as it did not work as expected

lkluft commented 4 years ago

I do not really see your point. _rh_func is an attribute of the FixedRH class and stores the relative humidity model that is uses. _rh_profile is an attribute of the CacheFromAtmosphere class and stores the cached relative humidity profile retrieved form the initial atmosphere. Of course, I could rename the second, but I don't see the advantage.

SallyDa commented 4 years ago

Ah sorry, now I get it :)

lkluft commented 4 years ago

No problem 😉Thanks for the review!