Implementation of a T-dependent C-shaped RH

atmtools / konrad

Implementation of a radiative-convective equilibrium model.

MIT License

19 stars 18 forks source link

Implementation of a T-dependent C-shaped RH #157

Closed stella-bourdin closed 3 years ago

stella-bourdin commented 3 years ago

Improve and correct the pre-existing way to fix a perturbation in T instead of p
Modifies PolynomialCShaped RH so that the part above the freezing level is a function of T

stella-bourdin commented 3 years ago

Hi, In this PR I already replaced the PolynomialCShaped with BetterCShaped, which no longer exists (unless I did something wrong with my PR that would not be up-to-date with my own code, which is possible...).

lkluft commented 3 years ago

Oh yes, you replaced it 😅 I pushed some minor changes, namely:

ValueError for RH > 0
Fix comment on how the freezing-level pressure is interpolated
Actually use the interpolated freezing-level pressure in your method

If you are fine with these changes, I will merge the PR :)

stella-bourdin commented 3 years ago

Oops yes I might have done that a bit too quickly ! Sounds good to me !