stella-bourdin
commented
3 years ago Here are my suggestions for relative_humidity.py :
- Are VerticallyUniform and ConstantFreezingLevel still useful ? If yes, clarify the difference with HeightConstant, and get more explicit names.
- Check for redundancies between FixedUTH, CoupledUTH, CshapedConstant, CshapedDecrease and PolynomialCShaped
- Rename PolynomialCshapedRH into PolynomialCshaped or something even more explicit depending on the decisions made in the last step
- Merge Manabe67, Romps14, Cess76, if still relevant, into a single FromLiterature function ? Or into ProfileFromData ?
- Maybe PerturbProfile is too specific for a baseline version
In stratosphere.py I only use ColdPointCoupling. NonIncreasing and MinimumStratosphericVMR seem quite specific.
I feel like surface and lapserate component are already quite lean. I used both options for surface depending on what I wanted to do, and the options in lapserate seem representative of the basic options one might want to explore.
lkluft
The plan is to remove outdated or unused modules, classes, or functions in the konrad source code. This will result in a minimised code base that, hopefully, is easier to document and maintain. Ideally, the code base will be simple enough to add missing unit tests for the remaining components.
In a next step, based on this streamlined version of konrad, it will be possible to review and update existing documentation and add further information for new users in the form of tutorials.
Collection of components/classes that can be removed