search

atmtools / konrad

Implementation of a radiative-convective equilibrium model.
MIT License
19 stars 18 forks source link

Fix non-McICA runs #30

Closed lkluft closed 5 years ago

lkluft commented 5 years ago

This PR fixes runs without McICA.

I got an exception when trying to run konrad with mcica=False because _cloud_ice_properties was not set. I guess it is fine to set it always, for ne non-McICA cases it should simply be ignored?

lkluft commented 5 years ago

Please do not merge, yet! 😉

SallyDa commented 5 years ago

We will normally not be using mcica=False when we want clouds, so in that case the cloud properties won't do anything. However if we use it for overcast simulations, it could make a difference. Damn it, I need more documentation :( I'll look into the fortran files and check.

lkluft commented 5 years ago

But even for mcica=False and full overcast it is possible to change it (as user). The point of this PR is only to always set the property 😉

SallyDa commented 5 years ago

Yes, fine. Anyway it seems to be identical to that for mcica, so as long as it isn't set to ebert_curry_one it should be fine.