search

atmtools / konrad

Implementation of a radiative-convective equilibrium model.
MIT License
19 stars 18 forks source link

Add simple `CloudEnsemble` #35

Closed lkluft closed 5 years ago

lkluft commented 5 years ago

Reopen the PR after major restructure of repository branches.

I will check the old PR #32 to sew which changes we agreed on.

lkluft commented 5 years ago

I am still not satisfied with the result. But I guess it should work for now?

I do not like the fact that we initialise the clouds using z, was there a reason except for preserving the cloud thickness (in meters)? And also the separate implementations of PhysicalCloud and DirectInputCloud feels artificial at some places 🤔

lkluft commented 5 years ago

I haven't checked every functionality and I still have to rewrite the __add__ special method. But I hope that most of the revision is done.

lkluft commented 5 years ago

That's it! I hope I implemented all features that we discussed.

This definitely needs some proper testing, but I guess this will be done by using the model (I hate myself for saying this).

I tried to keep the documentation up-to-date, but I am not sure if I found all changes. But I am planning a review of all docstrings, anyhow 😉