atmtools / konrad

Implementation of a radiative-convective equilibrium model.
MIT License
19 stars 18 forks source link

Revise humidity component #52

Closed lkluft closed 5 years ago

lkluft commented 5 years ago

This PR:

I am not completely sure if that is the final form (especially when it comes to naming of the classes, should we introduce suffixes e.g. Manabe67_RH?). Anyhow, I want to know your opinion on the general approach. My main goals were to 1) make the single classes more readable and 2) allow for a more flexible configuration of the humidity model.

lkluft commented 5 years ago

Thanks! :relaxed: Are you fine with the class names? I am not sure if we should try to make them more distinguishable because all are visible in the konrad.humidity namespace.

PS.: I want to rebase before the merging 😉 So please don't merge yourself 😄

SallyDa commented 5 years ago

Yeah, I'm fine with the class names. I see what you mean about the namespace but it's fine for now, you can always change it later if you come up with a good solution for that.