search

atn832 / fake_cloud_firestore

BSD 2-Clause "Simplified" License
119 stars 93 forks source link

Fix: concurrent list modification #282

Closed jonasN5 closed 10 months ago

jonasN5 commented 10 months ago

Fixes our own issue, which is the same as https://github.com/atn832/fake_cloud_firestore/issues/263

atn832 commented 10 months ago

Since it's been a while since you published this, I'll merge and clean it up myself. Here's a few notes:

  1. Your test file name should end with _test.dart. Otherwise flutter test will ignore it: https://github.com/atn832/fake_cloud_firestore/actions/runs/6813320080/job/18950530874?pr=282
  2. I recommend setting your IDE to reformat the code on each save. Otherwise the Dart Format job will complain.
  3. The test case worked but it was a bit complicated for my poor little brain. :) I'll simplify it separately.
atn832 commented 10 months ago

I published your fix to https://pub.dev/packages/fake_cloud_firestore/changelog#244. Thank you!