atn832 / fake_cloud_firestore

BSD 2-Clause "Simplified" License
118 stars 88 forks source link

Feature/support mocking server timestamp #287

Closed ming-chu closed 6 months ago

ming-chu commented 6 months ago

This PR is going to provide the interface for mocking the server timestamp. Btw, I am pretty sure that there are lots of better solutions than mine.

Any advice or comments are welcome.

Thank you for maintaining such an amazing plugin. I appreciated it! ❤️

@atn832

ming-chu commented 6 months ago

@atn832 Thank you for the review and I resolved them according to your suggestions. Please feel free to check and comment.

Thank you very much!!

atn832 commented 6 months ago

I made tiny tweaks at https://github.com/atn832/fake_cloud_firestore/commit/1036aa2f85c321d0dbeea0b7f525661bd9c99c46. Basically in this project's classes, we first put private variables, then constructors, then methods and getter/setters.

ming-chu commented 6 months ago

I made tiny tweaks at 1036aa2. Basically in this project's classes, we first put private variables, then constructors, then methods and getter/setters.

No problem, I will keep it in mind and follow it next time. Thank you very much!