search

atn832 / fake_cloud_firestore

BSD 2-Clause "Simplified" License
118 stars 88 forks source link

fix: compatibility for listeners with different converters #295

Closed diegogarciar closed 1 month ago

diegogarciar commented 4 months ago

Why?

Snapshot listeners built with a converter will not hear updates made from a reference without a converter Fixes #294

What?

Re added the previous code we had before #284 when the query type doesn't match, I couldn't think of a better solution but I'm open to ideas.

diegog-sf commented 4 months ago

Hello @atn832 could you have a look at this? its a one line change :)

atn832 commented 3 months ago

Hi @diegog-sf thanks for reporting the issue. It's a one line change but every fix needs a test to prevent further regressions. Are you able to write a simple test that reproduces the issue you mentioned? I'll try to find time to look at it more closely this week.

diegog-sf commented 3 months ago

Thanks, will do over the weekend

diegogarciar commented 1 month ago

hey @atn832 longest weekend ever, but I was finally able to add the tests :)

atn832 commented 1 month ago

Amazing thank you!! I'll take a look in the next few days. Btw the Analyzer issue doesn't seem related to this PR. I'll check separately later.

diegogarciar commented 1 month ago

Feedback addressed, I think I also fixed the analyzer issues

atn832 commented 1 month ago

Thank you for the bug fix, the nice tests and the analyzer fix! I just published your code to https://pub.dev/packages/fake_cloud_firestore/changelog#252.