search

atom-archive / electron-starter

Example Electron app
MIT License
530 stars 66 forks source link

Fix script test #50

Closed outsideris closed 9 years ago

outsideris commented 9 years ago 
./script/test
Node: v0.10.35
npm: v1.4.28
Installing build modules...
Installing apm...
Installing modules ✓
Deduping modules ✓
/bin/sh: node_modules/.bin/grunt: No such file or directory

In script/test, --gruntfile option is absent. So, I added it. And then in build/Gruntfile.coffee, "publish-build" task doesn't exist. So, I removed it. I don't know what "publish-build" task is for. Please check again it.

mcolyer commented 9 years ago

@outsideris this changes look good to me. Since we don't currently run this in CI, I didn't check if this part was working correctly when I implemented the test system.

Also if you'd like to avoid the bootstrapping part while running test you can execute ./script/run -rt . from inside the base directory or use the test window from inside the application.

outsideris commented 9 years ago

@mcolyer Thanks you for your information to run tests. I run ./script/test, to run test cases. But I found it's not working. I realized the script run grunt ci, their names aren't match and it's not for running test cases. Anyway, I think it's broken script, so I fixed it. Because I'm digging atom-shell-starter structure.