search

atom-archive / electron-starter

Example Electron app
MIT License
530 stars 66 forks source link

Offer the ability to use grunt-download-electron instead of grunt-build-atom-shell #83

Closed almathie closed 6 years ago

almathie commented 9 years ago

Quite a lot here are linked to the infamous build-atom-shell grunt task. See : https://github.com/atom/electron-starter/issues/69 https://github.com/atom/electron-starter/issues/77 https://github.com/atom/electron-starter/issues/54

Besides the issues some people are facing, this task is slow. The last time I needed to add a package to the manifest, it took more than 8 hours to complete I have a bad connection and all, but still.

The build atom-shell task seems only needed to generate a "binary" of the electron app. This could be replaced by "gunt-download-electron" which would fetch (and cache!) the binary.

As @kakaol mentioned here : https://github.com/atom/electron-starter/issues/71 the build step seems needed for the icon and the executable. For deployment/release this is important. In "dev mode" I would happily trade an executable name and an icon if this allowed me to iterate more quickly.

So, would it be feasible to have an optional --dev switch on the build (and run ?) task to use the downlad grunt task instead of the build one.

anaisbetts commented 9 years ago

The problem is until recently, grunt-download-electron was production usable on all platforms literally only for Atom itself. This is recently no longer the case, so I'll probably switch to using grunt-download-electron instead

jgeurts commented 9 years ago

Would love to see this functionality... the build-atom-shell task is painful

westoque commented 9 years ago

:+1: same here. painful waiting for build-atom-shell task to complete.

lllama commented 9 years ago

This could probably help with development under Windows as well given that the electron build fails.

lee-dohm commented 6 years ago

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use electron-prebuilt and electron-packager instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!