atom-archive / node-runas

Run command synchronously (with Administrator privilege)
MIT License
47 stars 20 forks source link

atom build fails with runas@3.1.1 but works with 3.1.0 #26

Closed alexm closed 6 years ago

alexm commented 8 years ago

Both atom v1.8.0 and master use runas@3.1.1 and fail when building atom in Debian jessie:

alexm@xps: (master) ~/git/atom$ script/build
Node: v0.10.29
npm: v1.4.21
Installing build modules...
In file included from ../src/main.cc:1:0:
../node_modules/nan/nan.h:324:47: error: ‘REPLACE_INVALID_UTF8’ is not a member of ‘v8::String’
   static const unsigned kReplaceInvalidUtf8 = v8::String::REPLACE_INVALID_UTF8;
                                               ^
make: *** [Release/obj.target/runas/src/main.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/share/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:809:12)
gyp ERR! System Linux 3.16.0-4-amd64
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /scratch/alexm/git/atom/build/node_modules/runas
gyp ERR! node -v v0.10.29
gyp ERR! node-gyp -v v0.12.2
gyp ERR! not ok 
npm ERR! runas@3.1.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the runas@3.1.1 install script.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! System Linux 3.16.0-4-amd64
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "--userconfig=/scratch/alexm/git/atom/build/.npmrc" "install" "--loglevel" "error"
npm ERR! cwd /scratch/alexm/git/atom/build
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /scratch/alexm/git/atom/build/npm-debug.log
npm ERR! not ok code 0

Setting version 3.1.0 in package.json instead:

alexm@xps: {master} /scratch/alexm/git/atom$ git diff
diff --git a/package.json b/package.json
index 1f38d17..6e8d58f 100644
--- a/package.json
+++ b/package.json
@@ -48,7 +48,7 @@
     "property-accessors": "^1.1.3",
     "random-words": "0.0.1",
     "resolve": "^1.1.6",
-    "runas": "^3.1",
+    "runas": "3.1.0",
     "scandal": "^2.2",
     "scoped-property-store": "^0.17.0",
     "scrollbar-style": "^3.2",

Works fine:

alexm@xps: {master} ~/git/atom$ script/build
Node: v0.10.29
npm: v2.13.3
Installing build modules...
=> Took 15476ms.

Installing apm...
=> Took 82820ms.

Deleting old packages...
=> Took 420ms.

Installing modules ✓
Installing atom-dark-syntax@0.27.0 ✓
...
lee-dohm commented 6 years ago

All repositories in the atom-archive organization are unmaintained and deprecated. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!