search

atom-archive / node-runas

Run command synchronously (with Administrator privilege)
MIT License
47 stars 20 forks source link

uprade to nan-1.1.2 #7

Closed duralog closed 10 years ago

duralog commented 10 years ago

for compiling on node-0.11.13 this upgrades to nan-1.1.2

cheers

zcbenz commented 10 years ago

atom-shell is still using node v0.11.10, which is not supported by nan 1.x, we should wait until atom-shell upgrades to node v0.11.13

duralog commented 10 years ago

aha, sounds good. we're on normal node v0.11.13 (not atom) so naturally I thought it'd be nice to push the changes back.

so I didn't actually know about atom-shell before. your comment made me investigate. it's really really cool and gave me some good ideas! I decided to try the 0.11.13 update myself, and got nearly everything compiling (including the regex library - I'll send that PR in a second), however I am hesitant about the atom/node merge with upstream. it merged pretty cleanly, but then I realized that it compiles against brightray's libchromiumcontent v8 version, so I got a bunch of compile errors.. if I want a challenge, I might try that, but this turned out to be a much bigger deal than I thought.

wow dude, amazing work on atom-shell.

duralog commented 10 years ago

I kept going for a bit longer.. I discovered the OOM linking in windows blocking the chromium upgrade and a bunch of other stuff. this is a very impressive undertaking. wow man, good luck.

zcbenz commented 10 years ago

Closing this in favor of #10.