Closed dwillitzer closed 5 years ago
I too have same issue.
The dependencies in package.json has a version of pty.js
point to a custom one
"dependencies": {
"pty.js": "http://gh-contractor-zcbenz.s3.amazonaws.com/temp/pty.js-0.2.4.tgz",
when I build with it, I get error.
Installing modules ✗
> pty.js@0.2.4 install /Users/bsr/Work/Tools/repo/terminal/node_modules/pty.js
> node-gyp rebuild
CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from ../src/unix/pty.cc:16:
../node_modules/nan/nan.h:352:13: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:332:50: note: expanded from macro '_NAN_ERROR'
# define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))
~~~~~~~~~~~~^
../node_modules/nan/nan.h:356:5: error: no member named 'ThrowException' in namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:337:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg)); \
~~~~^
../node_modules/nan/nan.h:356:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It builds fine with any of the official pty.js
(tried with all the versions 2.4 till 2.7.1 from https://github.com/chjj/pty.js/releases). After apm link, when atom opens it gives the undefined
error as reported by @djdesign
[Enter steps to reproduce below:]
Atom Version: 1.0.7 System: Ubuntu 14.04.3 Thrown From: terminal package, v0.28.0
Failed to activate the terminal package
At undefined is not a function
TypeError: undefined is not a function
at Object.module.exports.activate (/home/piotr/.atom/packages/terminal-master/lib/terminal.coffee:13:18)
at Package.module.exports.Package.activateNow (/opt/atom/resources/app.asar/src/package.js:243:19)
at /opt/atom/resources/app.asar/src/package.js:224:30
at Package.module.exports.Package.measure (/opt/atom/resources/app.asar/src/package.js:167:15)
at Package.module.exports.Package.activate (/opt/atom/resources/app.asar/src/package.js:216:14)
at PackageManager.module.exports.PackageManager.activatePackage (/opt/atom/resources/app.asar/src/package-manager.js:486:21)
at /opt/atom/resources/app.asar/src/package-manager.js:469:29
at Config.module.exports.Config.transact (/opt/atom/resources/app.asar/src/config.js:311:16)
at PackageManager.module.exports.PackageManager.activatePackages (/opt/atom/resources/app.asar/src/package-manager.js:464:19)
at PackageManager.module.exports.PackageManager.activate (/opt/atom/resources/app.asar/src/package-manager.js:445:46)
at Atom.module.exports.Atom.startEditorWindow (/opt/atom/resources/app.asar/src/atom.js:673:21)
at Object.<anonymous> (/opt/atom/resources/app.asar/src/window-bootstrap.js:12:8)
at Object.<anonymous> (/opt/atom/resources/app.asar/src/window-bootstrap.js:23:4)
at Module._compile (module.js:452:26)
at Object.loadFile [as .js] (/opt/atom/resources/app.asar/src/babel.js:163:21)
at Module.load (module.js:347:32)
at Function.Module._load (module.js:302:12)
at Module.require (module.js:357:17)
at require (module.js:376:17)
at setupWindow (file:///opt/atom/resources/app.asar/static/index.js:96:23)
at window.onload (file:///opt/atom/resources/app.asar/static/index.js:36:7)
{
"core": {
"themes": [
"atom-dark-ui",
"atom-dark-syntax"
]
}
}
# User
No installed packages
# Dev
No dev packages
All repositories in the atom-archive organization are unmaintained and deprecated. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!
[Enter steps to reproduce below:]
Atom Version: 0.208.0 System: Mac OS X 10.10.4 Thrown From: terminal package, v0.28.0
Stack Trace
Failed to activate the terminal package
Commands
Config
Installed Packages