Clip invalid positions while seeking

atom-archive / text-document

MIT License

57 stars 10 forks source link

Clip invalid positions while seeking #4

Closed as-cii closed 9 years ago

as-cii commented 9 years ago

As said on #3, code-wise this still needs some adjustments. However I wanted to demonstrate how we could sanitize position while seeking on TransformIterator and clip accordingly whenever needed.

Hopefully, this is the way to go: otherwise, well, let's just close this :laughing:

/cc: @nathansobo @maxbrunsfeld

maxbrunsfeld commented 9 years ago

Nice, thanks @as-cii!

as-cii commented 9 years ago

@maxbrunsfeld: :+1: about the duplication comment.

By the way, this PR was against ns-clipping and therefore I think it didn't make it into master.

I am away from keyboard and I cannot fix it right now unfortunately: sorry for the misunderstanding 🙏