search

atom-archive / xray

An experimental next-generation Electron-based text editor
MIT License
8.48k stars 235 forks source link

Get rid of Webpack #141

Closed joshaber closed 5 years ago

joshaber commented 5 years ago

Bundling WebAssembly with Webpack turns out to be ... complicated. It's easier for consumers if we just compile the TS to JS and let them worry about bundling.

nathansobo commented 5 years ago

Argh, trouble with this is that our tests run in Node and rely on WebPack running. Gonna see if I can find a workaround.

nathansobo commented 5 years ago

Hey @joshaber, I'm hoping this will go green. Node can't run the output of wasm-bindgen without running webpack on it, at least I couldn't make it work. So for the sake of the tests and also any other Node-based consumers of this library, I restored the use of webpack just for the main entry point. The web entry point continues to point at a version compiled directly with tsc as in your last commit. Will this work?

joshaber commented 5 years ago

Ahh yeah that makes sense. Good catch @nathansobo 🤘

I had to update the lockfile but otherwise those changes look good to me 👍

nathansobo commented 5 years ago

Oops. I think the lockfile got lost in the shuffle. Thanks. Published this as 1.0.4.