Closed joshaber closed 5 years ago
Argh, trouble with this is that our tests run in Node and rely on WebPack running. Gonna see if I can find a workaround.
Hey @joshaber, I'm hoping this will go green. Node can't run the output of wasm-bindgen without running webpack on it, at least I couldn't make it work. So for the sake of the tests and also any other Node-based consumers of this library, I restored the use of webpack just for the main
entry point. The web
entry point continues to point at a version compiled directly with tsc
as in your last commit. Will this work?
Ahh yeah that makes sense. Good catch @nathansobo 🤘
I had to update the lockfile but otherwise those changes look good to me 👍
Oops. I think the lockfile got lost in the shuffle. Thanks. Published this as 1.0.4.
Bundling WebAssembly with Webpack turns out to be ... complicated. It's easier for consumers if we just compile the TS to JS and let them worry about bundling.