FlatBuffers backwards compatibility

atom-archive / xray

An experimental next-generation Electron-based text editor

MIT License

8.48k stars 235 forks source link

FlatBuffers backwards compatibility #161

Closed as-cii closed 5 years ago

as-cii commented 5 years ago

This pull request is a follow-up to #160. As @nathansobo pointed out, we want to make sure older clients don't throw errors when receiving operations they don't know about. Here I am attempting to fix that oversight in the following ways:

Ignore operations that have unrecognized variants (a12b361)
Allow backward-compatible support of new kinds of buffer operations (ec6d0b1)

/cc: @nathansobo

nathansobo commented 5 years ago

@as-cii I'll go ahead and leave this open in case you want to discuss wrapping all unions in a table to create a consistent pattern. I thought that was a cool idea and worth considering.

nathansobo commented 5 years ago

Actually, never mind. I think there's valuable work on this branch and we may as well merge it. We can follow up.