search

atom-archive / xray

An experimental next-generation Electron-based text editor
MIT License
8.47k stars 237 forks source link

Remove string refs #50

Closed matthewwithanm closed 6 years ago

matthewwithanm commented 6 years ago

String refs are legacy API and likely to be removed.

as-cii commented 6 years ago

Thanks for spotting this! It totally makes sense to use a bound method on the class to avoid allocating a closure every time render is called.

matthewwithanm commented 6 years ago

Plus there's a bit of a footgun that wound up killing Nuclide's perf bad once when we had a kind of expensive ref callback. 😣