search

atom-archive / xray

An experimental next-generation Electron-based text editor
MIT License
8.48k stars 235 forks source link

Not building on NodeJS 10 #97

Closed DesWurstes closed 6 years ago

as-cii commented 6 years ago

Thanks for this pull request, @DesWurstes. A couple of questions:

The diff looks totally fine but I'd like to understand this better before going ahead and merging it. Thanks!

DesWurstes commented 6 years ago

I get

error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".
error Found incompatible module

which is the same of https://github.com/airbnb/enzyme/issues/1637

it was fixed in https://github.com/anodynos/upath/pull/15

The fix can be viewed here: https://github.com/anodynos/upath/commit/8c5f4e10376ed1cd4553d9432297d39a34410c69

as-cii commented 6 years ago

Awesome, thanks for the explanation @DesWurstes!