search

atom-community / atom-ide-base

Atom IDE packages for Atom
https://atom.io/packages/atom-ide-base
Other
44 stars 10 forks source link

Provide more abstraction for overlays and float panes #50

Open illright opened 3 years ago

illright commented 3 years ago

They provide similar functionality, are similar in appearance, suffer from the same issues and even have similar codebases. I believe we could be more efficient at maintaining both datatip and signature help functionality if we combine it in a single package that provides two services.

Additionally, this one is now TypeScript'ified, while atom-ide-signature-help isn't.

lierdakil commented 3 years ago

This might make sense, with one caveat: signature help tooltip is similar to a datatip, but it has some distinct behaviours. In particular, you generally don't have dozens of datatips, but you can have dozens of signature helps (for overloaded functions). Being able to show one at a time and cycle through is a must (which is by the way something atom-ide didn't do particularly well)

aminya commented 3 years ago

As mentioned, they are different. The common code is already refactored and lives in atom-ide-base. Both use ViewContainer and ProviderRegister. But the remaining code is different.

We can make another abstraction on top of this, but I don't think it would be helpful.