search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

Feature: handling custom requests #129

Closed laughedelic closed 3 years ago

laughedelic commented 3 years ago

Ported https://github.com/atom/atom-languageclient/pull/249 to the new repo.

aminya commented 3 years ago

The CI failure is fixed in #131

aminya commented 3 years ago

@laughedelic Could you take a look at the suggestions?

laughedelic commented 3 years ago

@aminya yes, thanks for the review! I'll try to address it tonight.

aminya commented 3 years ago

@laughedelic are you able to reword the commits to start with fix: a lowercase word? If you are away from the keyboard, I can do that.

laughedelic commented 3 years ago

@aminya is it ok if I just squash them into one with the right format?

aminya commented 3 years ago

I'd prefer separate commits because it gives us more flexibility later for a potential reverting.

You can use the following to reword all the commits one by one:

git rebase -i 488f0033e8e8698a68becce2d78f35745318545e

Then find and replace pick with r in the opened document, and reword, save, and close one by one.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: