atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

test: simplify autocomplete-paths tests by removing createCompletionItem #130

Closed aminya closed 3 years ago

aminya commented 3 years ago

Description

This removes the createCompletionItem function from the tests and just uses CompletionItem directly. This simplifies the tests, so we no longer need to update this function in two places as LSP changes.

CompletionItem requires label property which is added explicitly in the tests.

aminya commented 3 years ago

The CI failure is fixed in #131

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: