search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

feat: implement window/showDocument #135

Closed aminya closed 3 years ago

aminya commented 3 years ago

Implements ShowDocumentAdapter, which adapts the window/showDocument command to Atom's text editors or external programs.

Extracted from #112

aminya commented 3 years ago

The tests fail for different reasons on Windows vs Unix. Not sure if my uri for opening the fixture is correct

UziTech commented 3 years ago

apparently atom.workspace.open does different things when given an invalid path on windows and linux.

aminya commented 3 years ago

apparently atom.workspace.open does different things when given an invalid path on windows and linux.

That's a bug that should be taken care of inside Atom itself.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: