search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

feat: add support for workspace folders #153

Closed aminya closed 3 years ago

aminya commented 3 years ago

Adds support for WorkspaceFolders as described here:

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_workspaceFolders

aminya commented 3 years ago

Atom crashes inside the CI on Ubuntu and macOS after the tests are down. It might be related to this issue: https://github.com/atom/atom/issues/22024

They started crashing when I added the FakeAutoLanguageClient which actually spawns a server.

aminya commented 3 years ago

I tested it with ide-d and it seems to work.

UziTech commented 3 years ago

We should get the tests passing before we merge this otherwise it is going to be harder to know when tests for other PRs are passing. Even if we have to skip some tests.

aminya commented 3 years ago

We should get the tests passing before we merge this otherwise it is going to be harder to know when tests for other PRs are passing. Even if we have to skip some tests.

I made the tests working. I'm on Windows, so not sure why the CI fails on Ubuntu and MacOS.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

aminya commented 3 years ago

Please do not squash the pull requests. I need to disable squash for this organization altogether so people don't do it by mistake

UziTech commented 3 years ago

Why not? squashing the commits of a PR makes the release notes much cleaner and includes the PR# so anyone can still see each commit.

aminya commented 3 years ago

We should not sacrifice the version control for the sake of semantic release change log generation. If the issue is that, we should stop using automatically generated release notes.

Related to this: https://github.com/atom/atom/issues/22081

UziTech commented 3 years ago

but because it is squashed there is no way to see what issue comes from which change

Not true, this PR will still exist with the commits. And it will be easier to find since it will be in the release notes.

people are used to assessing the life of a project based on the commits pushed to the master

That seems like an error on their part. Like judging software by number of lines of code or “measuring aircraft building progress by weight” -- Bill Gates

By the way, both of those arguments seem contrary to your arguments for combining dependency updates.

I would much rather have those issues than have to write release notes manually for every release 🤣.