search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

Fix text completions #18

Closed aminya closed 3 years ago

aminya commented 4 years ago

We should start with this: https://github.com/atom/atom-languageclient/pull/254

UziTech commented 4 years ago

When I looked into copying that PR to this repo it looks like most of the code has already been updated. I'm not sure how to rebase that PR onto the changes that have happened since it was opened.

jonboiser commented 3 years ago

A similar bug was reported downstream in the ide-python library.

https://github.com/atom-community/ide-python/issues/251

I was able to isolate it to the change here made in #100. When I revert the change on my local copy of ide-python's dependencies, it fixes the issue. So there might be some interaction between the two issues.

aminya commented 3 years ago

A similar bug was reported downstream in the ide-python library.

atom-community/ide-python#251

I was able to isolate it to the change here made in #100. When I revert the change on my local copy of ide-python's dependencies, it fixes the issue. So there might be some interaction between the two issues.

Thanks for the report. I transferred the issue.

aminya commented 3 years ago

Sometimes when I press TAB nothing gets written by autocomplete.

UziTech commented 3 years ago

Sometimes when I press TAB nothing gets written by autocomplete.

That seems like an issue for the autocomplete package.

UziTech commented 3 years ago

I'm pretty sure test completions are fixed in v1.0.6

If there are still issues create another issue with specific details.