search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
44 stars 13 forks source link

fix(convert/pathToUri): Improve the encoding of non-alphanumeric paths other than the file protocol #183

Closed ayame113 closed 3 years ago

ayame113 commented 3 years ago

resolve ayame113/atom-ide-deno#74

There is a difference in the conversion process between Convert.uriToPath and Convert.pathToUri.

function (arguments -> retuen value)
uriToPath() https://foo.bar/%40->https://foo.bar/%40
https://foo.bar/%2540->https://foo.bar/%2540
pathToUri() https://foo.bar/%40->https://foo.bar/%2540

The decoding process of urls other than file: was changed by https://github.com/atom-community/atom-languageclient/commit/6f1e149c052888ff00c26b79be66e7bc7109d84f, but it seems that the encoding process was not changed. This PR modifies the encoding process for paths other than file: .

ayame113 commented 3 years ago

Oops, the test failed, so I'll fix it. I fixed. This is ready for review.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.16.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: