atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

semantic release #90

Closed UziTech closed 3 years ago

UziTech commented 3 years ago

v1.0.0 is published :tada:

We should setup semantic release.

@aminya do you want to take care of that? I allowed atom-ide-community to publish atom-languageclient so we can use an organization token on NPM.

You should also set up the deps update github action so we don't get so many update commits. Just make sure to create the PR with a GitHub PAT so tests run.

aminya commented 3 years ago

Yes. We should set the semantic release job. I can help with that.

Regarding the dependencies, I will add the proper job for bumping the deps. I can set up two separate jobs, one for devDeps and one for deps. This allows us to not merge the devDeps updates until it is a considerable change.

aminya commented 3 years ago

We should create a semantic release config for npm packages, so we can use it for all the npm packages.

Some examples: https://github.com/kettil/semantic-release-config/blob/master/index.js https://github.com/hexonet/semantic-release-github-npm-config/blob/master/.releaserc.json https://github.com/traverson/semantic-release-config/blob/master/shareable-config.json https://github.com/artemv/simple-semantic-config/blob/master/index.js

UziTech commented 3 years ago

Sounds good to me. Can you take care of that?

aminya commented 3 years ago

I am afraid I am busy these days.

UziTech commented 3 years ago

ok I'll make a minimal config template.

aminya commented 3 years ago

The config package is registered. Just use our previous template and change its config:

       - name: Release 🎉
         uses: cycjimmy/semantic-release-action@v2
         with:
           extends: |
             @atom-ide-community/semantic-release-npm-config
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN  }}
UziTech commented 3 years ago

semantic-release is working :tada: