atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

chore: add bump_deps action using ncu #93

Closed aminya closed 3 years ago

aminya commented 3 years ago

This uses ncu instead of the dependent bot which offers more control and flexibility.

We need to remove the dependent bot after this.

Closes #92 Closes #91

UziTech commented 3 years ago

This action won't run the tests when the PR is created if we use GITHUB_TOKEN to create it.

aminya commented 3 years ago

I'll merge this since we have been using it in other repositories. Testing it in action requires waiting until the bot getting actually triggered.

aminya commented 3 years ago

This action won't run the tests when the PR is created if we use GITHUB_TOKEN to create it.

Should I remove GITHUB_TOKEN?

UziTech commented 3 years ago

We should use a different token.

UziTech commented 3 years ago

it defaults to GITHUB_TOKEN if we don't provide one.

aminya commented 3 years ago

I am OK with using a token. These actions are safe and are widely used by the community.

UziTech commented 3 years ago

If you have access to @atom-ide-community-bot we should use that account

UziTech commented 3 years ago

You could create an organization secret with the PAT something like GH_TOKEN. That way we can use it in the other repos.

aminya commented 3 years ago

Unfortunately, I don't have access to that bot. I can create the token by my own account.

UziTech commented 3 years ago

that will work too.

UziTech commented 3 years ago

FYI here is the information about why it doesn't run tests with GITHUB_TOKEN

https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

aminya commented 3 years ago

The action suggests creating a GitHub app: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens

UziTech commented 3 years ago

That could work too.

aminya commented 3 years ago

The lock file on the master seems old. I'll remove and generate it again.