Closed aminya closed 3 years ago
This action won't run the tests when the PR is created if we use GITHUB_TOKEN
to create it.
I'll merge this since we have been using it in other repositories. Testing it in action requires waiting until the bot getting actually triggered.
This action won't run the tests when the PR is created if we use
GITHUB_TOKEN
to create it.
Should I remove GITHUB_TOKEN?
We should use a different token.
it defaults to GITHUB_TOKEN
if we don't provide one.
I am OK with using a token. These actions are safe and are widely used by the community.
If you have access to @atom-ide-community-bot we should use that account
You could create an organization secret with the PAT something like GH_TOKEN
. That way we can use it in the other repos.
Unfortunately, I don't have access to that bot. I can create the token by my own account.
that will work too.
FYI here is the information about why it doesn't run tests with GITHUB_TOKEN
The action suggests creating a GitHub app: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens
That could work too.
The lock file on the master seems old. I'll remove and generate it again.
This uses ncu instead of the dependent bot which offers more control and flexibility.
We need to remove the dependent bot after this.
Closes #92 Closes #91