search

atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

chore: Update devDependencies #97

Closed atom-ide-community-robot[bot] closed 3 years ago

atom-ide-community-robot[bot] commented 3 years ago

Automated changes by create-pull-request GitHub action

UziTech commented 3 years ago

@aminya are we waiting to merge this for some reason?

aminya commented 3 years ago

So, for dev dependencies, we should wait until the changes become considerable. This PR updates @types packages + Sinon. If you think upgrading Sinon makes a difference, we should merge this. Otherwise, we can wait until this have more meat.

For dependencies, we should merge them as soon as possible and then release them in a fix release

UziTech commented 3 years ago

sounds good. I'm ok with not updating devdeps until there is a major update. can we get ncu to only update devdeps on major releases?

UziTech commented 3 years ago

actually it is probably ok to leave devdeps the way they are so we test each version.

aminya commented 3 years ago

Yes, it's better to monitor this over time.

Do not consider these as a hard rule. For example, it makes sense to merge these PRs before applying other fixes or merging the actual deps bumps.

The author of the commit seems incorrect. I thought it will become @atom-ide-community-robot, but apparently, GitHub apps do not have separate emails and GitHub IDs.