atom-community / atom-languageclient

Provide integration support for adding Language Server Protocol servers to Atom.
https://www.npmjs.com/package/atom-languageclient
MIT License
45 stars 13 forks source link

Bug: code completion removes dot #99

Closed SvenMoenig closed 3 years ago

SvenMoenig commented 4 years ago

selecting an item from the code completion removes the dot before after

$ apm list Built-in Atom Packages (93) ├── atom-dark-syntax@0.29.1 ├── atom-dark-ui@0.53.3 ├── atom-light-syntax@0.29.1 ├── atom-light-ui@0.46.3 ├── base16-tomorrow-dark-theme@1.6.0 ├── base16-tomorrow-light-theme@1.6.0 ├── one-dark-ui@1.12.5 ├── one-light-ui@1.12.5 ├── one-dark-syntax@1.8.4 ├── one-light-syntax@1.8.4 ├── solarized-dark-syntax@1.3.0 ├── solarized-light-syntax@1.3.0 ├── about@1.9.1 ├── archive-view@0.65.2 ├── autocomplete-atom-api@0.10.7 ├── autocomplete-css@0.17.5 ├── autocomplete-html@0.8.8 ├── autocomplete-plus@2.42.3 ├── autocomplete-snippets@1.12.1 ├── autoflow@0.29.4 ├── autosave@0.24.6 ├── background-tips@0.28.0 ├── bookmarks@0.46.0 ├── bracket-matcher@0.91.2 ├── command-palette@0.43.5 ├── dalek@0.2.2 ├── deprecation-cop@0.56.9 ├── dev-live-reload@0.48.1 ├── encoding-selector@0.23.9 ├── exception-reporting@0.43.1 ├── find-and-replace@0.219.3 ├── fuzzy-finder@1.14.2 ├── github@0.34.2 ├── git-diff@1.3.9 ├── go-to-line@0.33.0 ├── grammar-selector@0.50.1 ├── image-view@0.64.0 ├── incompatible-packages@0.27.3 ├── keybinding-resolver@0.39.0 ├── line-ending-selector@0.7.7 ├── link@0.31.6 ├── markdown-preview@0.160.2 ├── metrics@1.8.1 ├── notifications@0.71.0 ├── open-on-github@1.3.2 ├── package-generator@1.3.0 ├── settings-view@0.261.4 ├── snippets@1.5.1 ├── spell-check@0.76.1 ├── status-bar@1.8.17 ├── styleguide@0.49.12 ├── symbols-view@0.118.4 ├── tabs@0.110.0 ├── timecop@0.36.2 ├── tree-view@0.228.0 ├── update-package-dependencies@0.13.1 ├── welcome@0.36.9 ├── whitespace@0.37.7 ├── wrap-guide@0.41.0 ├── language-c@0.60.19 ├── language-clojure@0.22.8 ├── language-coffee-script@0.50.0 ├── language-csharp@1.1.0 ├── language-css@0.44.4 ├── language-gfm@0.90.8 ├── language-git@0.19.1 ├── language-go@0.47.2 ├── language-html@0.53.1 ├── language-hyperlink@0.17.1 ├── language-java@0.31.5 ├── language-javascript@0.134.1 ├── language-json@1.0.5 ├── language-less@0.34.3 ├── language-make@0.23.0 ├── language-mustache@0.14.5 ├── language-objective-c@0.16.0 ├── language-perl@0.38.1 ├── language-php@0.44.5 ├── language-property-list@0.9.1 ├── language-python@0.53.4 ├── language-ruby@0.72.23 ├── language-ruby-on-rails@0.25.3 ├── language-rust-bundled@0.1.0 ├── language-sass@0.62.1 ├── language-shellscript@0.28.2 ├── language-source@0.9.0 ├── language-sql@0.25.10 ├── language-text@0.7.4 ├── language-todo@0.29.4 ├── language-toml@0.20.0 ├── language-typescript@0.6.3 ├── language-xml@0.35.3 └── language-yaml@0.32.0

Community Packages (27) /home/moenig/.atom/packages ├── atom-django@0.3.2 ├── atom-file-icons@0.7.1 ├── atom-ide-base@2.1.1 ├── atom-ide-datatip@0.20.4 ├── atom-ide-definitions@0.4.0 ├── atom-ide-hyperclick@1.0.9 ├── atom-ide-javascript@1.5.0 ├── atom-ide-markdown-service@1.6.0 ├── atom-ide-outline@1.12.1 (disabled) ├── atom-ide-signature-help@0.13.1 (disabled) ├── atom-ide-ui@0.13.0 ├── atom-typescript@14.0.2 ├── autocomplete-paths@2.12.2 ├── busy-signal@2.0.1 ├── django-templates@0.5.0 ├── file-type-icons@1.3.4 ├── ide-css@0.3.5 ├── ide-python@1.5.1 ├── intentions@1.1.5 ├── javascript-drag-import@0.1.13 ├── language-conky@0.2.0 ├── language-lua@0.9.11 ├── linter@3.1.1 ├── linter-eslint@8.5.5 ├── linter-ui-default@2.1.4 ├── logo-file-icons@1.13.0 └── svn@0.0.14

lgeiger commented 4 years ago

As far as I can tell atom-ide-community/ide-python#213 broke this. Not sure what changed between the atom-languageclient versions (the release notes do not mention any breaking changes). @aminya Do you know what changes in atom-language client could cause autocomplete to break?

Immanuel84 commented 4 years ago

Same issue here. Running Atom v.1.52.0 on MacOS X 10.11.6, python 3.8.6 (from macports)

Built-in Atom Packages (93) ├── atom-dark-syntax@0.29.1 ├── atom-dark-ui@0.53.3 ├── atom-light-syntax@0.29.1 ├── atom-light-ui@0.46.3 ├── base16-tomorrow-dark-theme@1.6.0 ├── base16-tomorrow-light-theme@1.6.0 ├── one-dark-ui@1.12.5 ├── one-light-ui@1.12.5 ├── one-dark-syntax@1.8.4 ├── one-light-syntax@1.8.4 ├── solarized-dark-syntax@1.3.0 ├── solarized-light-syntax@1.3.0 ├── about@1.9.1 ├── archive-view@0.65.2 ├── autocomplete-atom-api@0.10.7 ├── autocomplete-css@0.17.5 ├── autocomplete-html@0.8.8 ├── autocomplete-plus@2.42.3 ├── autocomplete-snippets@1.12.1 ├── autoflow@0.29.4 ├── autosave@0.24.6 ├── background-tips@0.28.0 ├── bookmarks@0.46.0 ├── bracket-matcher@0.91.2 ├── command-palette@0.43.5 ├── dalek@0.2.2 ├── deprecation-cop@0.56.9 ├── dev-live-reload@0.48.1 ├── encoding-selector@0.23.9 ├── exception-reporting@0.43.1 ├── find-and-replace@0.219.5 ├── fuzzy-finder@1.14.2 ├── github@0.34.2 ├── git-diff@1.3.9 ├── go-to-line@0.33.0 ├── grammar-selector@0.50.1 ├── image-view@0.64.0 ├── incompatible-packages@0.27.3 ├── keybinding-resolver@0.39.0 ├── line-ending-selector@0.7.7 ├── link@0.31.6 ├── markdown-preview@0.160.2 ├── metrics@1.8.1 ├── notifications@0.71.0 ├── open-on-github@1.3.2 ├── package-generator@1.3.0 ├── settings-view@0.261.5 ├── snippets@1.5.1 ├── spell-check@0.76.1 ├── status-bar@1.8.17 ├── styleguide@0.49.12 ├── symbols-view@0.118.4 ├── tabs@0.110.0 ├── timecop@0.36.2 ├── tree-view@0.228.0 ├── update-package-dependencies@0.13.1 ├── welcome@0.36.9 ├── whitespace@0.37.7 ├── wrap-guide@0.41.0 ├── language-c@0.60.19 ├── language-clojure@0.22.8 ├── language-coffee-script@0.50.0 ├── language-csharp@1.1.0 ├── language-css@0.44.4 ├── language-gfm@0.90.8 ├── language-git@0.19.1 ├── language-go@0.47.2 ├── language-html@0.53.1 ├── language-hyperlink@0.17.1 ├── language-java@0.31.5 ├── language-javascript@0.134.1 ├── language-json@1.0.5 ├── language-less@0.34.3 ├── language-make@0.23.0 ├── language-mustache@0.14.5 ├── language-objective-c@0.16.0 ├── language-perl@0.38.1 ├── language-php@0.44.7 ├── language-property-list@0.9.1 ├── language-python@0.53.5 ├── language-ruby@0.72.23 ├── language-ruby-on-rails@0.25.3 ├── language-rust-bundled@0.1.0 ├── language-sass@0.62.1 ├── language-shellscript@0.28.2 ├── language-source@0.9.0 ├── language-sql@0.25.10 ├── language-text@0.7.4 ├── language-todo@0.29.4 ├── language-toml@0.20.0 ├── language-typescript@0.6.3 ├── language-xml@0.35.3 └── language-yaml@0.32.0

Community Packages (33) /Users/user/.atom/packages ├── atom-clock@0.1.18 ├── atom-ide-base@2.1.1 ├── autocomplete-clang@0.13.1 (disabled) ├── autocomplete-python-jedi@1.10.3-0 (disabled) ├── battery-status@0.11.11 ├── bracket-colorizer@1.4.0 ├── build@0.70.0 ├── busy-signal@2.0.1 ├── close-on-left@0.9.2 ├── file-icons@2.1.43 ├── gitlab@0.1.3-7 (disabled) ├── highlight-column@0.5.4 ├── highlight-line@0.12.0 ├── highlight-selected@0.17.0 ├── ide-docker@0.1.0 ├── ide-python@1.5.1 ├── intentions@1.1.5 (disabled) ├── language-ini@1.23.0 ├── linter@3.1.1 (disabled) ├── linter-docker@0.3.2 ├── linter-gcc2@0.8.8 ├── linter-ui-default@2.1.4 (disabled) ├── markdown-pdf@2.3.3 ├── nms-color-bracket@0.1.0 (disabled) ├── one-dark-vivid-syntax@1.8.1 ├── pdf-view@0.72.0 ├── platformio-ide@2.7.2 ├── platformio-ide-debugger@1.2.6 ├── platformio-ide-terminal@2.10.0 (disabled) ├── project-manager@3.3.8 ├── purple-rain@0.4.8 ├── terminus@4.0.6 └── tool-bar@1.4.1

lgeiger commented 4 years ago

For now I reverted atom-ide-community/ide-python#213. Could you test if this issue is fixed in ide-python@v1.5.2?

Immanuel84 commented 4 years ago

For now I reverted atom-ide-community/ide-python#213. Could you test if this issue is fixed in ide-python@v1.5.2? Just tested, it works! Thank you!

aminya commented 4 years ago

@UziTech we should investigate this

UziTech commented 4 years ago

Looks like https://github.com/atom/atom-languageclient/pull/264 is the offending PR that adds the . to the replacementPrefix. I'll try to fix it soon.

aminya commented 4 years ago

I think this is also related to https://github.com/atom-ide-community/atom-languageclient/issues/18.

We might have to recover the removed tests from https://github.com/atom/atom-languageclient/pull/264