search

atom-community / atom

:atom: Community build of the hackable text editor
https://atom-community.github.io/
MIT License
738 stars 30 forks source link

Bump tree sitter #403

Closed mauricioszabo closed 2 years ago

mauricioszabo commented 2 years ago

Please, merge after this PR otherwise grammars will break: https://github.com/atom-community/atom/pull/399

This PR bumps tree-sitter to a recent version. It also uses "NPM's tree sitter", not an Atom/git specific one.

I know this code works with Electron 12. Unfortunately, ./script/bootstrap and friends do not work on my machine, so I have no way of testing if the "current way" of building Atom also works...

Also, this PR is basically https://github.com/atom-community/atom/pull/386, but splitted into bumping tree-sitter. I'll open another bumping Electron (but it's also dependent on this one, unfortunately)

aminya commented 2 years ago

Changed the target branch so we have some buffer to fix the tests before the final merge.

aminya commented 2 years ago

I cannot push to this branch. Could you enable push access? We need #4ffbf92aa

icecream17 commented 2 years ago

Btw, you might've not seen this note from my pr:

I've added these repos to packages but I'm not actually updating the package.json for these packages:

  • language-c
  • language-css
  • language-go
  • language-javascript

I could update package and package-lock (if access is given)

mauricioszabo commented 2 years ago

I cannot push to this branch. Could you enable push access

You meant, my branch on my repo, @aminya? If so, I just gave you access.

aminya commented 2 years ago

@icecream17 What about merging it to our branch and then applying the changes on the repo we have access to?

aminya commented 2 years ago

I made a new PR based on our branch: Here you go: https://github.com/atom-community/atom/pull/416