atom-community / atom

:atom: Community build of the hackable text editor
https://atom-community.github.io/
MIT License
738 stars 30 forks source link

Add error condition + Expand timeout #410

Closed icecream17 closed 2 years ago

icecream17 commented 2 years ago

One of the tests that fail in the newer windows. Edit: See #428

If all paths are processed but not all paths were deleted out, the error is "expired", so I added an error condition to have it say "not all paths found" instead.

My instinct says this error condition probably isn't happening, but it would be nice to guarantee one way or other.

Expand timeout 2 --> 3 seconds


Edit: MacOS failed on the error condition I added somehow??? It seems like all I'm doing is mapping some of one error into another, but now that this happened I'm not sure what's going on.

Theory: Previously, the if statement is skipped, the function returns, the promise resolves, and the test finishes before there's time for the setTimeout to error. But now there's the "else" statement causing an error. Don't know what's different about MacOS