atom-community / atom

:atom: Community build of the hackable text editor
https://atom-community.github.io/
MIT License
738 stars 30 forks source link

Revert #446 changes #449

Closed ghost closed 2 years ago

ghost commented 2 years ago

Requirements for Contributing Documentation

Description of the Change

Reverts #446.

Release Notes

N/A

ghost commented 2 years ago

cc @ElectronicsArchiver

ghost commented 2 years ago

I prefer the current design because the more important buttons come first. The badges are not useful for most people.

What? @ElectronicsArchiver said it's ugly, so I made this. So I don't agree why.

aminya commented 2 years ago

Most people want to download Atom and use it (used to be two million people). We only have a handful of developers who build Atom.

I find neither ugly.

ElectronicsArchiver commented 2 years ago

Well maintainers have the last word..

Good thing that this is only a maintenance project and Atoms UI has long been finished~

ElectronicsArchiver commented 2 years ago

Most people want to download Atom and use it (used to be two million people). We only have a handful of developers who build Atom.

And thats why the building button is on the same level as the installation button? Not a great argument if you ask me..

ghost commented 2 years ago

I prefer the current design because the more important buttons come first. The badges are not useful for most people.

@aminya The badges are useful because they guide you to helpful links.

They are useful for starters.

For Example:

The Discord will be useful to talk to everyone in that server about something

icecream17 commented 2 years ago

I also prefer the current design fwiw, just because it looks nicer to me. The badges don't seem smushed together at all, in fact having them together feels more connected?

I think maybe it's just the size of everything; the banner then the h1 then the badges seems more pleasing than putting badges between header and banner, and in general more important things like the title go before subtitle/content:

image

Also the badges just happen to be in a funnel shape.

Maybe the ugly thing about it is the spacing? (header->badge smaller than badge->badge whitespace) image

Note that my opinion isn't very strong on this; it isn't very clear to me that this is an improvement, unlike say, regular links to badges.

I'll just let consensus build about this though, since I don't feel like giving more effort on the readme

ElectronicsArchiver commented 2 years ago

You could also just put them before the banner and 'out of the way', thus bringing the focus on the 'important' things -> Buttons.