Fix "Upload Artifacts" job in CI (makes CI pass)

[DeeDeeG]

Requirements for Contributing a Bug Fix (from template, click to expand):

* Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. * The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at . * The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see . * After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see .

Identify the Bug

CI isn't passing, because it tries to upload binary blobs to Azure Storage, but without the needed credentials. This errors out, causing CI to fail (even after the build and tests may have succeeded.)

Description of the Change

• Update script/vsts/upload-artifacts.js to skip uploading binary blobs to Azure Storage if env var ATOM_RELEASES_AZURE_CONN_STRING is unset or empty (more precisely: if it is falsy in JS).
• Update the "Upload CI Artifacts" job in the CI YAML files so that it uses the intermediate variables workaround, which makes sure env vars will be seen as undefined/empty in scripts.
  • This is restoring a part of the solution we had before (from https://github.com/atom-community/atom/pull/99), but I think it got reverted during a merge of upstream commits at some point?
• Use unshortened URL in the comment explaining the workaround
  • (This is an optional change, not super important. Just my personal preference.)

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

CI should pass if this PR is done right.

NOTE: The PR pipeline will not test this change. I will manually run the release branch pipeline on my personal CI instance to see if it passes. CI passing directly on this PR will be the "Pull Requests" pipeline, which has nothing to do with this change.

Update: It works for me on my personal CI instance: CI link

Environment variable "process.env.ATOM_RELEASES_AZURE_CONN_STRING," is not set, skipping Azure upload.

Release Notes

N/A

[DeeDeeG]

It worked on my personal CI instance:

Passing CI on Release Branch Build pipeline on my CI: link to passing CI run

See this line specifically, from the output of my CI run's "Upload Artifacts" job:

Environment variable "process.env.ATOM_RELEASES_AZURE_CONN_STRING," is not set, skipping Azure upload.

There is a tiny typo -- I included an unnecessary comma in the console.log() string when skipping upload to Azure... Can fix that real quick if wanted. Edit: I pushed a commit to delete the extra comma.