search

atom-community / buildium

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/buildium
MIT License
3 stars 2 forks source link

HTMLDocument.registerElement is deprecated. #14

Open masashiro0jack opened 1 year ago

masashiro0jack commented 1 year ago

Use customElements.define instead of document.registerElement see https://javascript.info/custom-elements

HTMLDocument.registerElement (file:///opt/Pulsar/resources/app.asar/static/index.js:99:12)
registerElement (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:66:88)
Builder.openTag (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:297:27)
Builder.tag (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:274:12)
Function.div (/home/famin/.pulsar/packages/buildium/node_modules/space-pen/lib/space-pen.js:83:49)
Function.value (/home/famin/.pulsar/packages/buildium/lib/buildium.js:1:37843)
idleberg commented 1 year ago

While this pack is affected by this deprecation, it needs to be fixed in the space-pen package. But since that has been deprecated by GitHub, the second best choice would be reporting this issue in the space-pen-plus. Once a fix is available, replacing the dependency on that package should be trivial.

The alternative would be rewriting the UI, which probably won't happen anytime soon (if at all).

idleberg commented 1 year ago

→ https://github.com/atom-community/space-pen-plus/issues/3