atom-community / markdown-preview-plus

Markdown Preview + Community Features
https://atom.io/packages/markdown-preview-plus
Other
370 stars 84 forks source link

Preview Tab blank after updating to Atom 1.47.0 #487

Closed jamiejenkins closed 4 years ago

jamiejenkins commented 4 years ago

All preview are blank after updating to Atom 1.47.0 (or beta 1.48.0).

I've also raised an issue on atom https://github.com/atom/atom/issues/20754

lierdakil commented 4 years ago

Okay, Atom 1.47 made the switch to Electron 5. Electron 5 disables webview by default, which is used for preview isolation in MPP. Atom 1.47 doesn't enable webview tags.

It is in theory possible to switch to BrowserView, but that entails a massive re-write, which I can't do at the moment. So hopefully upstream fixes this.

jamiejenkins commented 4 years ago

Looks like they merged the fix to enable webview. Hopefully that will fix it. Thanks for taking the time to look at it.

aricooperdavis commented 4 years ago

In the meantime, one workaround is to use the browser extension markdown-viewer which renders markdown in the browser. You'll want to enable local files and autoreload for a similar experience.

jamiejenkins commented 4 years ago

Thanks, this looks nice and I can use it on Windows & Chrome but not on my macOS & Safari setup. I've rolled back to 1.46.0 on macOS. And I do still prefer to have the atom package as it would be on all platforms I use.

shernandezsantana commented 4 years ago

One can also revert atom to 1.46 as a temporary solution: sudo snap revert atom

aubreyz commented 4 years ago

Same here - no longer working - blank preview

lierdakil commented 4 years ago

"Me too" comments aren't helpful considering the issue is already confirmed and pinpointed.

TL;DR: downgrade to Atom 1.46, 1.47.0 is currently broken.

1.48.0 should be fine once released unless upstream messes up. Can't say anything about 1.47.1 (and whether there will be such a release at all)

langley commented 4 years ago

FYI, I'm running

Then I installed

And that "fixed" the "Preview Tab blank after updating" issue described here.

aubreyz commented 4 years ago

Surely that is not fixing the present plugin (markdown-it-preview uses the same default key keybinding) - you are just using a different plugin and different markdown parser. But it does suggest the problem is with some previewers in the current Atom update (the best HTML previewer https://github.com/harmsk/atom-html-preview also breaks in Atom 1.47 with the same blank screen, perhaps related).

lierdakil commented 4 years ago

Then I installed markdown-it-preview 0.2.5

That's as far as I can tell an abandoned project, which doesn't have most features associated with MPP. You could just as well use the built-in markdown-preview package, I think.

But it does suggest the problem is with some previewers in the current Atom update

For the love of all the 3 million Hindu gods, read the thread! The issue is discovered, pinpointed, explained in literally the second comment, and is fixed in the master branch of Atom repo. Just downgrade to 1.46, skip 1.47 and wait for the next release.

I'm seriously tempted to lock the thread at this point.

CodeLover-1999 commented 4 years ago

Can you elaborate on how to downgrade?Is to uninstall the new version and reinstall the old version?

lierdakil commented 4 years ago
  1. Disable autoupdates in Atom's core settings
  2. Download the relevant package from https://github.com/atom/atom/releases/tag/v1.46.0 and install it.

Details will differ depending on your OS.

Elieu commented 4 years ago

Encountered the same issue with atom 1.47.0 and markdown-preview-plus 3.11.5.

aubreyz commented 4 years ago

Kill the thread if you like -- but it does raise several issues as to how the beta-testing for atom is carried out when it can kill several widely used and important plugins (such as this one) and still, be released regardless (and then not rapidly at least reverted if not fixed). I am deeply appreciative of all the work carried out, but still .... I want atom to be the go to editor, and this doesn't help.

lierdakil commented 4 years ago

@aubreyz, I share your sentiment, but there is not much I can do. I'll go try to nudge upstream, but I'm not holding my breath.

MarkHaakman commented 4 years ago

It is fixed in v1.48.0 which is just released!