search

atom-community / minimap-plus

:warning: Deprecated - use the original minimap
https://atom.io/packages/minimap-plus
2 stars 0 forks source link

feat: use requestAnimationFrame for scheduleChanges #12

Closed aminya closed 4 years ago

aminya commented 4 years ago

This allows skipping the frames if the browser is busy doing other things, and it will improve the overall experience

References: https://blog.teamtreehouse.com/efficient-animations-with-requestanimationframe

aminya commented 4 years ago

@DeeDeeG @UziTech Could you check and see if you notice better performance? Try editing and typing in a large file. The benchmarks show improvement, and I feel it myself too. I want to know how it is on your side. You can set redraw delay to 0 to really see the effect of this pull request.

DeeDeeG commented 4 years ago

If I clone this branch and do apm install in the cloned repo root, will that add it to my Atom? I'm new to installing Atom packages from git repos.

aminya commented 4 years ago

No, you need to clone it under .atom/packages. I usually use symbolic links instead of copy-pasting there. There is also apm dev which is basically the same symbolic thing.

DeeDeeG commented 4 years ago

I installed it and am using it. Will see if I can/can't reproduce and let you know some time later.

UziTech commented 4 years ago

you can clone it anywhere and use apm link to create a symlink in .atom/packages

UziTech commented 4 years ago

you can also use apm link --name {package-name} to create a symlink with a different name in case you are testing different versions of a package.

aminya commented 4 years ago

I want to merge this. Did you see any problem with this?

DeeDeeG commented 4 years ago

I didn't notice any problems in the short time I tested.

I was on a low frame rate "remote viewing" connection to my strong PC at the time, so confirming any performance difference in terms of smooth scrolling was difficult; Icouldn't definitively say it was faster or slower. Sorry I did not find another time to test this.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 4.33.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: