search

atom-community / terminal

Terminal integrated with atom-community/atom
https://atom.io/packages/atomic-terminal
Other
19 stars 4 forks source link

Cannot find module './element' #45

Closed UziTech closed 3 years ago

UziTech commented 3 years ago

image

Error: Cannot find module './element'
Require stack:
- C:\Users\tjbrix\Documents\projects\GitHub\terminal\dist\terminal.js
- C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app.asar\static\index.html
    at Module._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Module._resolveFilename (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\electron.asar\common\reset-search-paths.js:41:16)
    at Function.get_Module._resolveFilename (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:155387)
    at Module.require (file:///C:/Users/tjbrix/AppData/Local/atom-beta/app-1.55.0-beta0/resources/app.asar/static/index.js:61:43)
    at require (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:146720)
    at Object.<anonymous> (C:\Users\tjbrix\Documents\projects\GitHub\terminal\dist\terminal.js:1:447)
    at Object.<anonymous> (C:\Users\tjbrix\Documents\projects\GitHub\terminal\dist\terminal.js:4:3)
    at Module.get_Module._compile (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:147404)
    at Object.value [as .js] (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:150952)
    at Module.load (internal/modules/cjs/loader.js:645:32)
    at Function.Module._load (internal/modules/cjs/loader.js:560:12)
    at Module.require (file:///C:/Users/tjbrix/AppData/Local/atom-beta/app-1.55.0-beta0/resources/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:16:16)
    at customRequire (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:1:736589)
    at requireModule (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:14:1122229)
    at Package.requireMainModule (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:3591285)
    at Package.activateNow (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:3579269)
    at C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:14:2607
    at Function.simpleDispatch (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:1190181)
    at Emitter.emit (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:1191622)
    at PackageManager.triggerDeferredActivationHooks (C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:384090)
    at C:\Users\tjbrix\AppData\Local\atom-beta\app-1.55.0-beta0\resources\app\static\<embedded>:11:382841
UziTech commented 3 years ago

I don't know why rollup is just requiring ./element and ./model instead of bundling them.

image

aminya commented 3 years ago

Probably best to switch to Parcel. Rollup is annoying when there is a dynamic require in the file somewhere.

An alternative solution is to run tsc.build before running rollup so these files become available in the release

UziTech commented 3 years ago

Or we could just use atom-ts-transpiler and not have to worry about a build step since it doesn't create any perceived speed increase.