search

atom-community / terminal

Terminal integrated with atom-community/atom
https://atom.io/packages/atomic-terminal
Other
19 stars 4 forks source link

fix: update dependencies #72

Closed UziTech closed 3 years ago

UziTech commented 3 years ago

Ligatures work with webgl with this update :tada:

UziTech commented 3 years ago

@aminya I can't figure out why the parcel build is failing https://github.com/atom-community/terminal/pull/72/checks?check_run_id=2561634905#step:6:48

Have I mentioned how much I hate build steps? 😅

I fixed it by pinning the parcel version

aminya commented 3 years ago

Please pin the Parcel version. It is jumping to the latest nightly (apparently buggy).

aminya commented 3 years ago

Ok. The build succeeded.

UziTech commented 3 years ago

Now it is failing because of typescript:

> npm run build.tsc

> atomic-terminal@1.1.2 build.tsc
> tsc -p src/tsconfig.json

node_modules/xterm-addon-webgl/typings/xterm-addon-w
ebgl.d.ts:6:24 - error TS2307: Cannot find module 'n
ode-pty' or its corresponding type declarations.

6 import { IEvent } from 'node-pty';
                         ~~~~~~~~~~

Found 1 error.
aminya commented 3 years ago

It is because the definitions for node-pty are missing. Can't you install @types/node-pty? You can also set skipLibCheck to true in tsconfig.

UziTech commented 3 years ago

should be fixed by https://github.com/xtermjs/xterm.js/pull/3334

UziTech commented 3 years ago

It is because the definitions for node-pty are missing. Can't you install @types/node-pty?

There is no @types/node-pty package.

You can also set skipLibCheck to true in tsconfig.

This works but I'll wait a day or so for the fix on xterm.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: