fix: add padding to the terminal

[aminya]

Adds 8 pixels of padding that makes the terminal look better.

After - With padding (some space):

Before - Without padding:

[UziTech]

I think this should be something people can put in their custom stylesheet. I would rather have no padding and more space for content. It doesn't look good when the terminal is docked on the right side.

[UziTech]

or maybe make it a setting if we want people to find it easily.

[aminya]

It can be overridden from the user stylesheet. There is no reason to add settings for everything.

[UziTech]

I agree we should let the user add this to their stylesheet if they want padding. We should probably add it to the readme though so they can know what selector to use.

[aminya]

I think the other way around. We should design the package as best as we think. If someone wants to modify things, they have the capability to do so.

[UziTech]

We should design the package as best as we think.

Yes and I think it looks better without the padding.

[UziTech]

The padding takes up a lot of valuable space when the terminal is docked to the right side.

[UziTech]

maybe we could add the padding only when it is docked on the bottom?

[UziTech]

actually I just tried it and I still think it looks better without the padding on the bottom.

[aminya]

I don't know how you are testing this, but it looks very bad when docked to the right. See that there is no separation between the panes. The text is tangent to the left.

With padding (some space):

Without padding:

[UziTech]

My terminal usually isn't that wide so the more space for content the better. There is a border between the panes so it is easy to see where one pane ends and another begins without the padding.

with padding:

without padding:

[aminya]

It looks bad though. No separation between the panes, and as Jeff mentioned before, it looks janky.

If you prefer, I can change 8 pixels to something that is proportional to the size of 1 character.

[UziTech]

I still prefer none. Maybe we should do a poll on discord?

[aminya]

OK. That could be a poll. 😄

[UziTech]

Can you create it. I don't know how to do polls. We should have the options 0px, 2px, 8px, 1rem

[aminya]

1 rem doesn't work as I tested it.

If we want to get meaningful results, it would be better to have only two choices. No padding vs padding about the size of 1 character.

[UziTech]

about the size of 1 character.

wouldn't that be 1rem?

[aminya]

Yes. Now I tested it, and it works.

Here is 1rem

[UziTech]

Make the terminal about 200px wide and see if it looks good to you.

[aminya]

That's very narrow, but it still looks better with padding.

Without padding, the left side of the character is just on the left border, which looks bad:

[UziTech]

I disagree. For me the border is enough to tell the panes apart and having less wrapping is more important than more padding.

[aminya]

The result of the poll: 6 people voted for having padding, and 1 person voted for no padding.

[github-actions[bot]]

:tada: This PR is included in version 1.1.5 :tada:

The release is available on:

• GitHub release
• Atom package

Your semantic-release bot :package::rocket: