fix: use padding variable

atom-community / terminal

Terminal integrated with atom-community/atom

https://atom.io/packages/atomic-terminal

Other

19 stars 4 forks source link

fix: use padding variable #85

Closed UziTech closed 3 years ago

UziTech commented 3 years ago

We should use the ui padding variable to be consistent with tree-view and other elements

UziTech commented 3 years ago

also I don't think we should mess with the .xterm styling since it could conflict.

UziTech commented 3 years ago

actually I think we need to do the styling just on the left to prevent the scrollbar from moving over the width of the padding.

This seems to do what was intended by #81 since it still provides a separation between the letters and the border. Top, right, and bottom already have a padding due to the way the terminal is scrolled.

UziTech commented 3 years ago

I lied styling atomic-terminal makes the scrollbar move over so we do need to style .xterm.

This could break stuff in the future if xterm changes the way the width is calculated.

aminya commented 3 years ago

Yeah, last time I tried, I had to choose xterm class for proper padding.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.1.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: