Closed vivi90 closed 4 years ago
I have already added you as collaborator, can you check it once again
@sdinesh86 Unfortunately there is no settings tab.
What i want to do soon:
implement CI/CD with Travis CI
I would recommend using GitHub Actions for CI/CD. I maintain many Atom packages that use it. You can look at sync-settings as an example.
@sdinesh86 It seems, that the only way is to transfer this repo to an new created "organization". See here: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository#collaborator-access-on-a-repository-owned-by-a-user-account
Tip: If you require more granular read/write access to a repository owned by your user account, consider transferring the repository to an organization. For more information, see "Transferring a repository."
@UziTech I wanted to use this example: https://github.com/atom/ci/blob/master/.travis.yml But your way sounds interesting, so will i give it a try. :-) Btw: the spec tests are failing and i am still not familiar with Jasmine. Would be great, if you have an idea: https://github.com/sdinesh86/atom-music/issues/17
I'll take a look at the tests tonight and maybe do a PR for GitHub actions. 😁
@UziTech If you also create an GitHub Actions file, then may you please name the workflow "build"? :-) Because i want to add later such fancy badge to the README file for the users like here: https://github.com/vivi90/mitsu (Btw.: I will unpublish and delete the mitsu package later.)
Update: Mitsu package unpublished.
FYI you might want to look at music-time for some inspiration. Just released Yesterday.
@UziTech Thank you for this tip. It seems, that music-time needs Spotify. I want to avoid such requirements and keep atom-music independent. If you just push a fix for the broken specs, then i will do the other stuff. Otherwise i will soon remove the specs for now to avoid build failing status. (Yes i know, bad idea.)
@sdinesh86 We need access to the repository settings. Otherwise it's hard to continue it. See here: https://github.com/sdinesh86/atom-music/pull/23
For me there are 3 possibilities:
First option seems to be more better.
What do you think for the name of the organization ?
How about "mitsu"?
Or just atom-music
btw what does mitsu mean, in this case
"atom-extensions" is fine. Mitsu was the name of my fork of atom-music. This word is japanese and means different things, depending on how it is written. My idea was 「蜜」, what means nectar or honey (See: https://jisho.org/search/%E8%9C%9C). Because for me is music also something sweet, what i need for coding. :-)
@sdinesh86 We still need settings access. So i recommend to do it by creating a team "maintainers" for it.
For more about permissions see here: https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization
//EDIT: Steps 1 and 2 already done. For step 3 i get: 'You do not have sufficient permissions to add the atom-music repository to this team'
done check it once
@sdinesh86 To grant the whole team this access by step 3 and 4 would be better. Now i have maintain permissions but still not able to add tokens are needed here: https://github.com/atom-extensions/atom-music/pull/23 At least the settings for GitHub Pages are now available.
I have done that too
Project reorganization done. So i close this issue.
@sdinesh86 Is it possible, that i get write access of the repository settings? Want to add some documentation later.