search

atom-extensions / atom-music

🎵 Simple music player for Atom.
https://atom.io/packages/atom-music
MIT License
14 stars 10 forks source link

GitHub actions #23

Closed UziTech closed 4 years ago

UziTech commented 4 years ago

Use github actions for testing, linting and releasing with semantic-release

You will need to add your APM API Token to a GitHub secret called ATOM_ACCESS_TOKEN for automatic releases.

vivi90 commented 4 years ago

@UziTech @sdinesh86 Not able to use automatic releases because i have no settings acces to add the token.

vivi90 commented 4 years ago

@UziTech Cherry-picked and released you spec test fix (https://github.com/sdinesh86/atom-music/commit/1395edc06361a310c313f5e0892fe94564f05245) until we have a solution for the settings problem.

UziTech commented 4 years ago

I can comment out the release if you want so we at least get the CI. Then when the settings issue is dealt with all you will have to do in uncomment the release for CD.

vivi90 commented 4 years ago

@UziTech Yes, would be great. Please do so.

UziTech commented 4 years ago

I rebased and commented the release so this should be ready for testing and linting PRs

vivi90 commented 4 years ago

@UziTech Great, thank you. Looks good, will merge it.

vivi90 commented 4 years ago

@UziTech It seems you have missed something, because actions are not running.

vivi90 commented 4 years ago

@UziTech Fixed by: https://github.com/sdinesh86/atom-music/commit/4fdee02ad5f5dfea0b7967d60aa4175501f60f89 and https://github.com/sdinesh86/atom-music/commit/4052be173a65650869f43c58915545b3473a0f22

UziTech commented 4 years ago

oops acidentally created the .github folder inside the lib folder (❁´◡`❁)

vivi90 commented 4 years ago

@UziTech No problem.