atom-haskell-archive / autocomplete-haskell

Atom autocomplete-plus provider for haskell
https://atom.io/packages/autocomplete-haskell
MIT License
23 stars 1 forks source link

Autocomplete pastes the whole signature of the autocompleted function #21

Closed LukaHorvat closed 7 years ago

LukaHorvat commented 7 years ago

With the newest update, pressing enter in the autocomplete list results in the whole signature being included.

For example fmap<ENTER> plops this into the editor fmap :: Functor f => (a -> b) -> f a -> f b -- from:Functor with a newline at the end.

lierdakil commented 7 years ago

Uh... that shouldn't be the case (also can't repoduce on my end). Did you update haskell-ghc-mod as well? Also do try to restart Atom, that might help?

LukaHorvat commented 7 years ago

Yep, everything is updated. I'm on the release channel of Atom at the moment so I'm running 1.19.

Here's a recording https://dl.dropboxusercontent.com/s/0q6sszod04b09f2/2017-08-09_15-32-10.mp4

lierdakil commented 7 years ago

I think I might have an idea what's gone wrong. I have a vague recollection that you might be running on Windows?

lierdakil commented 7 years ago

If so, see if haskell-ghc-mod@v2.0.1 helps any.

LukaHorvat commented 7 years ago

I am on Windows but this didn't seem to help.

lierdakil commented 7 years ago

haskell-ghc-mod@v2.0.2 should hopefully help, although I'm not entirely sure what goes wrong here.

LukaHorvat commented 7 years ago

Hmm... Well, fmap now doesn't seem to appear in the autocomplete list (at least not as something autocomplete-haskell provides; only as an identifier already present in the file).

Some other functions do appear in the list and autocomplete works for them.

Also, operator autocompletion doesn't work anymore.

lierdakil commented 7 years ago

See if v2.0.3 fixes that =\

LukaHorvat commented 7 years ago

Nope. Seems the same. It looks like all the Prelude identifiers don't show up. Very weird.

lierdakil commented 7 years ago

Well, I've found a problem, that should be fixed in v2.0.4, but I have doubts this will help at this point. I will try to debug on Windows ASAP, but that might take a while... Sincerely sorry about that.

LukaHorvat commented 7 years ago

Hey, no worries. I can live without autocomplete for a bit. Thank you for the amazing response time, as usual.

LukaHorvat commented 7 years ago

Err.... It works now? I don't know which version fixed it, but it works with 2.0.5.

lierdakil commented 7 years ago

Huh. Okay then, 2.0.4 actually helped I guess? Since 2.0.5 was an unrelated fix...