search

atom-haskell-archive / haskell-ghc-mod

haskell-ghc-mod atom package
https://atom.io/packages/haskell-ghc-mod
MIT License
69 stars 20 forks source link

Exposed max buffer size as setting. #162

Closed DennisMcWherter closed 8 years ago

DennisMcWherter commented 8 years ago

I hit an issue where the spawned process was exceeding the max buffer size. I was able to fix this error by setting maxBuffer: Infinity in the options passed to the child process.

I have exposed this maxBuffer option as a setting and defaulted it to Number.MAX_VALUE (since atom won't display Infinity).

lierdakil commented 8 years ago

I wonder how you ran into this issue in the first place, but oh well.

I think it should be safe to just set ghc-mod(i)'s buffer size to infinity unconditionally? Having an option for this seems a bit counter-intuitive.

DennisMcWherter commented 8 years ago

@lierdakil good question :) I'm not exactly sure. I'm pulling in several libraries, but nothing too huge that I'm aware of (the largest one probably being Lens).

Anyway, I have updated the PR hardcoding maxBuffer to Infinity.

lierdakil commented 8 years ago

Okay, published as 1.14.7