search

atom-haskell-archive / haskell-ghc-mod

haskell-ghc-mod atom package
https://atom.io/packages/haskell-ghc-mod
MIT License
69 stars 20 forks source link

Use .hlint.yaml #209

Closed LukaHorvat closed 6 years ago

LukaHorvat commented 7 years ago

Currently it seems that the file is ignored. When I run hlint from the command line it takes the configuration into account, but linting from inside of the editor ignores it.

lierdakil commented 7 years ago

This is likely caused by the fact that ghc-mod runs hlint programmatically (as opposed to calling the binary). There are a couple known bugs, that should theoretically be fixed by https://github.com/DanielG/ghc-mod/pull/829. But that patch is unreleased as of now. Honestly, the release schedule of ghc-mod has been kinda horrible lately. At this point I'm kinda tempted to eschew ghc-mod entirely wrt linting, and instead use hlint directly, but that's quite a bit of work honestly, and makes setup that much more complicated, so yeah...

matonix commented 6 years ago

FYI: in my environment (ghc-mod version 5.8.0.0 compiled by GHC 8.0.2, haskell-ghc-mod version 2.1.0), the following option worked.

- ignore: {name: Eta reduce}
lierdakil commented 6 years ago

Well, that's because referenced PR finally found its way into ghc-mod 5.8. Thanks for the heads-up.