search

atom-haskell-archive / haskell-ghc-mod

haskell-ghc-mod atom package
https://atom.io/packages/haskell-ghc-mod
MIT License
69 stars 20 forks source link

Ligatures-font Hasklig in Atom 1.1.0 breaks type/info of selected symbol #62

Closed clojj closed 8 years ago

clojj commented 8 years ago

The ligature <$> isn't recognized... instead :info of '<' is shown

wrong-symbol

Depending on selection or cursor-position, the result differs. If the selection is extended one char to either side of the ligature, :info is correct !

screen shot 2015-11-04 at 23 44 56

lierdakil commented 8 years ago

This is a problem with Atom's rendering of ligatures. Namely, while it shows whole ligature selected, it actually selects only first character (< in this case). You can verify this by selecting a ligature and copy-pasting it.

You can select whole ligature (or part of it) with keyboard, but there is no visual confirmation. I believe monoid font doesn't suffer this problem.

imageimageimage

clojj commented 8 years ago

Fira Code does not have this problem. Ok, so this is probably a font-thing ?

Anyway, as more ligatures fonts will be used in the atom community, any issues with atom's font-handling will hopefully be resolved.

Because other fonts work well, I dont know if any issue should be filed in Atom's core repository.....?

Othewise, to me it looks ok to close this issue!

lierdakil commented 8 years ago

Well, opening an issue in Atom core repo can't hurt, and selecting whole ligature representation if ligature is selected seems like reasonable solution.

lierdakil commented 8 years ago

Not sure if it would be easy to implement though.